linux-kernel - Re: [PATCH 0/2] x86/entry: simplify RESTORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrW7Lg9YGeJ=xQ51Hd_XA8W0tCXNeSGDQYiEACd1+gy7Bg@mail.gmail.com>
Date:   Fri, 29 May 2020 11:17:21 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Lai Jiangshan <laijs@...ux.alibaba.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, X86 ML <x86@...nel.org>
Subject: Re: [PATCH 0/2] x86/entry: simplify RESTORE_CR3

On Mon, May 25, 2020 at 9:35 PM Lai Jiangshan <laijs@...ux.alibaba.com> wrote:
>
> When I searched percpu data touched by entry code for #DB
> protection[1], it seems to me RESTORE_CR3() does too much work,
> this patchset simplifies it.
>
> Patch 1 enhances 21e944591102("x86/mm: Optimize RESTORE_CR3") for
> kernel CR3.
>
> Patch 2 *reverts* 21e944591102("x86/mm: Optimize RESTORE_CR3") for
> User CR3.

This series looks correct, but I don't think it's 5.8 material.  I
also want to try moving all this code to C, so it's possible this
little series will become obsolete.

>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: x86@...nel.org
> Link: https://lore.kernel.org/lkml/20200525145102.122557-1-laijs@linux.alibaba.com
> Lai Jiangshan (2):
>   x86/entry: Don't write to CR3 when restoring to kernel CR3
>   x86/entry: always flush user CR3 in RESTORE_CR3
>
>  arch/x86/entry/calling.h  | 36 ++++++++----------------------------
>  arch/x86/entry/entry_64.S |  6 +++---
>  2 files changed, 11 insertions(+), 31 deletions(-)
>
> --
> 2.20.1
>