linux-kernel - Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <824d63d8-668c-22c8-a303-b44e30e805e1@gmail.com>
Date:   Sat, 30 May 2020 00:26:17 +0200
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Matthew Garrett <mjg59@...f.ucam.org>,
        Bjorn Helgaas <helgaas@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select
 CONFIG_PCIEASPM by default")

On 29.05.2020 22:59, Matthew Garrett wrote:
> On Fri, May 29, 2020 at 03:21:35PM -0500, Bjorn Helgaas wrote:
> 
>> Yeah, that makes sense.  I can't remember the details, but I'm pretty
>> sure there's a reason why we ask for the whole set of things.  Seems
>> like it solved some problem.  I think Matthew Garrett might have been
>> involved in that.
> 
> This was https://bugzilla.redhat.com/show_bug.cgi?id=638912 - some 
> firmware misbehaves unless you pass the same set of supported 
> functionality as Windows does.
> 

Current situation means that PME is unusable on all systems where
pcie_aspm_support_enabled() returns false, what is basically every
system except EXPERT mode is enabled and CONFIG_PCIEASPM is set.
So we definitely need to do something.

One question is whether the system from the 10yr old bug report
actually depends on OSC_PCI_EXPRESS_LTR_CONTROL control, or whether
some other change in recent years fixed the issue.
Not sure whether the system is still available for re-testing.

If worst case we have 10yr old systems breaking with a new kernel
then we still would have the workaround to enable CONFIG_PCIEASPM
on that system.