linux-kernel - Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 May 2020 15:26:30 +0800
From:   oulijun <oulijun@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        Wei Hu <huwei87@...ilicon.com>,
        Weihang Li <liweihang@...wei.com>,
        Doug Ledford <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>, <linux-rdma@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer
 raq



在 2020/5/28 23:04, Colin King 写道:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
> 
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index 8ff6b922b4d7..d02207cd30df 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
>   static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
>   {
>   	struct hns_roce_v1_priv *priv = hr_dev->priv;
> -	struct hns_roce_raq_table *raq = raq = &priv->raq_table;
> +	struct hns_roce_raq_table *raq = &priv->raq_table;
>   	struct device *dev = &hr_dev->pdev->dev;
>   	int raq_shift = 0;
>   	dma_addr_t addr;
> 
thanks