linux-kernel - Re: [PATCH 01/13] sysctl: add new register_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d06n17mm.fsf@intel.com>
Date:   Fri, 29 May 2020 11:13:21 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Luis Chamberlain <mcgrof@...nel.org>, keescook@...omium.org,
        yzaikin@...gle.com, nixiaoming@...wei.com, ebiederm@...ssion.com,
        axboe@...nel.dk, clemens@...isch.de, arnd@...db.de,
        gregkh@...uxfoundation.org, joonas.lahtinen@...ux.intel.com,
        rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
        benh@...nel.crashing.org, rdna@...com, viro@...iv.linux.org.uk,
        mark@...heh.com, jlbec@...lplan.org, joseph.qi@...ux.alibaba.com,
        vbabka@...e.cz, sfr@...b.auug.org.au, jack@...e.cz,
        amir73il@...il.com, rafael@...nel.org, tytso@....edu
Cc:     julia.lawall@...6.fr, akpm@...ux-foundation.org,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linuxppc-dev@...ts.ozlabs.org, ocfs2-devel@....oracle.com,
        linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH 01/13] sysctl: add new register_sysctl_subdir() helper

On Fri, 29 May 2020, Luis Chamberlain <mcgrof@...nel.org> wrote:
> Often enough all we need to do is create a subdirectory so that
> we can stuff sysctls underneath it. However, *if* that directory
> was already created early on the boot sequence we really have no
> need to use the full boiler plate code for it, we can just use
> local variables to help us guide sysctl to place the new leaf files.

I find it hard to figure out the lifetime requirements for the tables
passed in; when it's okay to use local variables and when you need
longer lifetimes. It's not documented, everyone appears to be using
static tables for this. It's far from obvious.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center