lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 May 2020 08:29:09 +0000 From: Dragan Cvetic <draganc@...inx.com> To: John Hubbard <jhubbard@...dia.com>, LKML <linux-kernel@...r.kernel.org> CC: Souptick Joarder <jrdr.linux@...il.com>, Derek Kiernan <dkiernan@...inx.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Michal Simek <michals@...inx.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() Hi John, Thank you for the suggestion, please find my comment below: > -----Original Message----- > From: John Hubbard <jhubbard@...dia.com> > Sent: Wednesday 27 May 2020 02:26 > To: LKML <linux-kernel@...r.kernel.org> > Cc: Souptick Joarder <jrdr.linux@...il.com>; John Hubbard <jhubbard@...dia.com>; Derek Kiernan <dkiernan@...inx.com>; Dragan > Cvetic <draganc@...inx.com>; Arnd Bergmann <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Michal Simek > <michals@...inx.com>; linux-arm-kernel@...ts.infradead.org > Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() > > Hi, > > There are also a couple of tiny cleanup patches, just to fix up a few > minor issues that I spotted while converting from get_user_pages_fast() > to pin_user_pages_fast(). > > Note that I have only compile-tested these patches, although that does > also include cross-compiling for a few other arches. Any run-time > testing would be greatly appreciated! > > Cc: Derek Kiernan <derek.kiernan@...inx.com> > Cc: Dragan Cvetic <dragan.cvetic@...inx.com> > Cc: Arnd Bergmann <arnd@...db.de> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: Michal Simek <michal.simek@...inx.com> > Cc: linux-arm-kernel@...ts.infradead.org > > John Hubbard (3): > misc: xilinx-sdfec: improve get_user_pages_fast() error handling > misc: xilinx-sdfec: cleanup return value in xsdfec_table_write() > misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages() Reviewed-by: Technically there is no problem in this patch, but as you said this should be tested. Currently due to Covid-19 I'm not able to access the HW and I cannot validate this suggestion. > > drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-) > > > base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145 > -- > 2.26.2
Powered by blists - more mailing lists