linux-kernel - Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c304a0b0-692a-0696-6750-05a3db6a4b42@web.de>
Date:   Fri, 29 May 2020 11:40:47 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Borislav Petkov <bp@...en8.de>, linux-edac@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Doug Thompson <dougthompson@...ssion.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        James Morse <james.morse@....com>, Kangjie Lu <kjlu@....edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Qiushi Wu <wu000273@....edu>,
        Robert Richter <rrichter@...vell.com>,
        Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] edac: Fix reference count leak in
 edac_device_register_sysfs_main_kobj()

>> * The label “err_out” can be replaced by direct return statement,
>>   can't it?
>
> No, it cannot. It keeps the error handling code out-of-line so that the
> function body remains readable.

Have we got different programming expectations also around the application
of the Linux coding style?

Regards,
Markus