linux-kernel - Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200529094813.GA29323@cnn>
Date:   Fri, 29 May 2020 15:18:13 +0530
From:   Manikandan <manikandan.hcl.ers.epl@...il.com>
To:     Vijay Khemka <vijaykhemka@...com>
Cc:     linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org, sdasari@...com, patrickw3@...com,
        vijaykhemka@...com, manikandan.e@....com
Subject: Re: [PATCH] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN

On Thu, May 28, 2020 at 05:34:22PM +0000, Vijay Khemka wrote:
> 
> 
> On 5/28/20, 7:15 AM, "Manikandan Elumalai" <manikandan.hcl.ers.epl@...il.com> wrote:
> 
>     
>     The adm1278 temperature sysfs attribute need it for one of the our openbmc platform . 
>     This functionality is not enabled by default, so PMON_CONFIG needs to be modified in order to enable it.
> 
> There is no Signed-off-by.
>     
>     ---
>      drivers/hwmon/pmbus/adm1275.c | 15 +++++++++++++++
>      1 file changed, 15 insertions(+)
>     
>     diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c
>     index 5caa37fb..47b293d 100644
>     --- a/drivers/hwmon/pmbus/adm1275.c
>     +++ b/drivers/hwmon/pmbus/adm1275.c
>     @@ -681,6 +681,21 @@ static int adm1275_probe(struct i2c_client *client,
>      			}
>      		}
>      
>     +		config = i2c_smbus_read_byte_data(client, ADM1275_PMON_CONFIG);
>     +		if (config < 0)
>     +			return config;
>     +
>     +		/* Enable TEMP1 by defult */
>     +		config |= ADM1278_TEMP1_EN;
>     +		ret = i2c_smbus_write_byte_data(client,
>     +					ADM1275_PMON_CONFIG,
>     +					config);
>     +		if (ret < 0) {
>     +		dev_err(&client->dev,
>     +			"Failed to enable temperature config\n");
>     +		return -ENODEV;
>     +		}
>     +
>      		if (config & ADM1278_TEMP1_EN)
> 
> This check becomes irrelevant as you are enabling it above then rather than
> enabling it just remove this check.
     Thanks for review Vijay. I will submit changes in v2.
> 
>      			info->func[0] |=
>      				PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
>     -- 
>     2.7.4
>     
>     
>