linux-kernel - Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 May 2020 12:16:08 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     bcm-kernel-feedback-list@...adcom.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-aspeed@...ts.ozlabs.org, linux-samsung-soc@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-pm@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, devel@...verdev.osuosl.org,
        vilhelm.gray@...il.com, syednwaris@...il.com,
        fabrice.gasnier@...com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, jic23@...nel.org, dan@...obertson.com,
        jikos@...nel.org, srinivas.pandruvada@...ux.intel.com,
        linus.walleij@...aro.org, wens@...e.org, hdegoede@...hat.com,
        rjui@...adcom.com, sbranden@...adcom.com, peda@...ntia.se,
        kgene@...nel.org, krzk@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, ak@...klinger.de, paul@...pouillou.net,
        milo.kim@...com, vz@...ia.com, slemieux.tyco@...il.com,
        khilman@...libre.com, matthias.bgg@...il.com, agross@...nel.org,
        bjorn.andersson@...aro.org, heiko@...ech.de, orsonzhai@...il.com,
        baolin.wang7@...il.com, zhang.lyra@...il.com, mripard@...nel.org,
        tduszyns@...il.com, rmfrfs@...il.com, lorenzo.bianconi83@...il.com,
        ktsai@...ellamicro.com, songqiang1304521@...il.com,
        tomislav.denis@....com, eajames@...ux.ibm.com,
        dmitry.torokhov@...il.com, coproscefalo@...il.com
Subject: Re: [PATCH 4/5] iio: light: lm3533-als: remove explicit parent
 assignment

On Fri, May 22, 2020 at 11:22:07AM +0300, Alexandru Ardelean wrote:
> This assignment is the more peculiar of the bunch as it assigns the parent
> of the platform-device's device (i.e. pdev->dev.parent) as the IIO device's
> parent.
>
> It's unclear whether this is intentional or not.
> Hence it is in it's own patch.

Yeah, we have a few mfd drivers whose child drivers registers their
class devices directly under the parent mfd device rather than the
corresponding child platform device.

Since it's done consistently I think you need to update them all if you
really want to change this. 

And it may not be worth it since at least in theory someone could now be
relying on this topology.

> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  drivers/iio/light/lm3533-als.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c
> index bc196c212881..0f380ec8d30c 100644
> --- a/drivers/iio/light/lm3533-als.c
> +++ b/drivers/iio/light/lm3533-als.c
> @@ -852,7 +852,6 @@ static int lm3533_als_probe(struct platform_device *pdev)
>  	indio_dev->channels = lm3533_als_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(lm3533_als_channels);
>  	indio_dev->name = dev_name(&pdev->dev);
> -	indio_dev->dev.parent = pdev->dev.parent;
>  	indio_dev->modes = INDIO_DIRECT_MODE;
>  
>  	als = iio_priv(indio_dev);

Johan