linux-kernel - Re: [PATCH V1] mmc: sdhci-msm: Clear tuning done flag while hs400 tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 May 2020 12:35:48 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Veerabhadrarao Badiganti <vbadigan@...eaurora.org>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "# 4.0+" <stable@...r.kernel.org>, Andy Gross <agross@...nel.org>,
        Ritesh Harjani <riteshh@...eaurora.org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>
Subject: Re: [PATCH V1] mmc: sdhci-msm: Clear tuning done flag while hs400 tuning

On Thu, 28 May 2020 at 17:14, Veerabhadrarao Badiganti
<vbadigan@...eaurora.org> wrote:
>
> Clear tuning_done flag while executing tuning to ensure vendor
> specific HS400 settings are applied properly when the controller
> is re-initialized in HS400 mode.
>
> Without this, re-initialization of the qcom SDHC in HS400 mode fails
> while resuming the driver from runtime-suspend or system-suspend.
>
> Fixes: ff06ce4 ("mmc: sdhci-msm: Add HS400 platform support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@...eaurora.org>

Applied for next, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-msm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 95cd973..b277dd7 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -1174,6 +1174,12 @@ static int sdhci_msm_execute_tuning(struct mmc_host *mmc, u32 opcode)
>         msm_host->use_cdr = true;
>
>         /*
> +        * Clear tuning_done flag before tuning to ensure proper
> +        * HS400 settings.
> +        */
> +       msm_host->tuning_done = 0;
> +
> +       /*
>          * For HS400 tuning in HS200 timing requires:
>          * - select MCLK/2 in VENDOR_SPEC
>          * - program MCLK to 400MHz (or nearest supported) in GCC
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
>