linux-kernel - Re: [PATCH] i2c: sh_mobile: Fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200529121245.GA20272@ninjato>
Date:   Fri, 29 May 2020 14:12:46 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Vincent Guittot <vincent.guittot@...aro.org>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: sh_mobile: Fix compilation warning

On Thu, May 09, 2019 at 10:13:46AM +0530, Viresh Kumar wrote:
> This currently generates a warning:
> 
> drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
> drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Though the code looks okay and shouldn't ever use the variable
> uninitialized.
> 
> Fix the warning by moving the code around and getting rid of 'data'.
> 
> Compile tested only.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Tested on a Renesas Lager board (R-Car H2). Dumping register sets
produces identical results.

Tested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

And code is actually cleaner now.

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)