lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <878shaud3c.fsf@x220.int.ebiederm.org>
Date:   Fri, 29 May 2020 07:42:31 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     keescook@...omium.org, yzaikin@...gle.com, nixiaoming@...wei.com,
        axboe@...nel.dk, clemens@...isch.de, arnd@...db.de,
        gregkh@...uxfoundation.org, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch, benh@...nel.crashing.org,
        rdna@...com, viro@...iv.linux.org.uk, mark@...heh.com,
        jlbec@...lplan.org, joseph.qi@...ux.alibaba.com, vbabka@...e.cz,
        sfr@...b.auug.org.au, jack@...e.cz, amir73il@...il.com,
        rafael@...nel.org, tytso@....edu, julia.lawall@...6.fr,
        akpm@...ux-foundation.org, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linuxppc-dev@...ts.ozlabs.org,
        ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/13] sysctl: add new register_sysctl_subdir() helper

ebiederm@...ssion.com (Eric W. Biederman) writes:

> Luis Chamberlain <mcgrof@...nel.org> writes:
>
>> Often enough all we need to do is create a subdirectory so that
>> we can stuff sysctls underneath it. However, *if* that directory
>> was already created early on the boot sequence we really have no
>> need to use the full boiler plate code for it, we can just use
>> local variables to help us guide sysctl to place the new leaf files.
>>
>> So use a helper to do precisely this.
>
> Reset restart.  This is patch is total nonsense.
>
> - You are using register_sysctl_table which as I believe I have
>   mentioned is a deprecated compatibility wrapper.  The point of
>   spring house cleaning is to get off of the deprecated functions
>   isn't it?
>
> - You are using the old nasty form for creating directories instead
>   of just passing in a path.
>
> - None of this is even remotely necessary.  The directories
>   are created automatically if you just register their entries.

Oh.  *blink*  The poor naming threw me off.

This is a clumsy and poorly named version of register_sysctl();

Yes. This change is totally unnecessary.

Eric

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ