[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3aea7a1c10e94ea2964fa837ae7d8fe2@AcuMS.aculab.com>
Date: Fri, 29 May 2020 13:08:37 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Casey Schaufler' <casey@...aufler-ca.com>,
David Howells <dhowells@...hat.com>,
Linus Torvalds <torvalds@...ux-foundation.org>
CC: Christoph Hellwig <hch@....de>, Al Viro <viro@...iv.linux.org.uk>,
"Ian Kent" <raven@...maw.net>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
LSM List <linux-security-module@...r.kernel.org>,
NetFilter <netfilter-devel@...r.kernel.org>
Subject: RE: clean up kernel_{read,write} & friends v2
From: Casey Schaufler
> Sent: 28 May 2020 22:21
> It's true, nobody uses a TTY33 anymore. Those of us who have done so
> understand how "{" is preferable to "BEGIN" and why tabs are better than
> multiple spaces. A narrow "terminal" requires less neck and mouse movement.
> Any width limit is arbitrary, so to the extent anyone might care, I advocate
> 80 forever.
A wide monitor is for looking at lots of files.
Not dead space because of deep intents and very long variable names.
Although i don't understand the 'indent continuations under "("' rule.
It hides some indents and makes other excessive.
A simple 'double indent' (or half indent) makes code more readable.
A different rule for function definitions would make real sense.
They only need a single indent - the '{' marks the end.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Powered by blists - more mailing lists