linux-kernel - Re: [PATCH 1/4] workqueue: void unneeded requeuing the pwq in rescuer thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200529142223.GC3530656@mtj.duckdns.org>
Date:   Fri, 29 May 2020 10:22:23 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Lai Jiangshan <laijs@...ux.alibaba.com>
Cc:     linux-kernel@...r.kernel.org,
        Lai Jiangshan <jiangshanlai@...il.com>
Subject: Re: [PATCH 1/4] workqueue: void unneeded requeuing the pwq in
 rescuer thread

On Fri, May 29, 2020 at 06:58:59AM +0000, Lai Jiangshan wrote:
> 008847f66c3 ("workqueue: allow rescuer thread to do more work.") made
> the rescuer worker requeue the pwq immediately if there may be more
> work items which need rescuing instead of waiting for the next mayday
> timer expiration.  Unfortunately, it checks only whether the pool needs
> help from rescuers, but it doesn't check whether the pwq has work items
> in the pool (the real reason that this rescuer can help for the pool).
> 
> The patch adds the check and void unneeded requeuing.
> 
> Signed-off-by: Lai Jiangshan <laijs@...ux.alibaba.com>

Applied to wq/for-5.8.

Thanks.

-- 
tejun