linux-kernel - Re: please revert "Revert "media: staging: atomisp: Remove driver""

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200529171433.06f12925@coco.lan>
Date:   Fri, 29 May 2020 17:14:33 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: please revert "Revert "media: staging: atomisp: Remove driver""

Em Fri, 29 May 2020 16:46:15 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> escreveu:

> On Fri, May 29, 2020 at 04:09:07PM +0200, Christoph Hellwig wrote:
> > Hi Mauro and Greg,
> > 
> > the commit mentioned in the subject (commit id ad85094b293e in
> > linux-next) contains the grave offense of adding a new set_fs address
> > space override in "new" code.  It also doesn't have an Ack from Greg
> > despite showing up in drives/staging, which looks very suspicious.
> > 
> > Please don't just add crap like this back if it doesn't pass the
> > most basic sanity tests.  
> 
> Mauro "owns" drivers/staging/media/ which is where this ended up in,
> right?  And I thought he had a bunch of follow-on patches that fixed up
> crud like set_fs and friends.
> 
> Mauro, is your fixes not pushed in your tree as well?

Yes, I'm pushing the fixes on my tree too, after giving them some time
for review at the mailing lists.

In any case, feel free to ping me if you find anything as bad as this
one.

Thanks,
Mauro