[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM7PR04MB715735B54F24293ABF7B37908B8C0@AM7PR04MB7157.eurprd04.prod.outlook.com>
Date: Sat, 30 May 2020 01:03:17 +0000
From: Peter Chen <peter.chen@....com>
To: Michał Mirosław <mirq-linux@...e.qmqm.pl>
CC: Felipe Balbi <balbi@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP
> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned
> intf, unsigned alt)
> > > /* we know alt == 0, so this is an activation or a reset */
> > >
> > > if (intf == acm->ctrl_id) {
> > > - dev_vdbg(&cdev->gadget->dev,
> > > - "reset acm control interface %d\n", intf);
> > > - usb_ep_disable(acm->notify);
> > > + if (acm->notify->enabled) {
> > > + dev_vdbg(&cdev->gadget->dev,
> > > + "reset acm control interface %d\n", intf);
> > > + usb_ep_disable(acm->notify);
> > > + }
> >
> > But it does not fix any issues, the usb_ep_disable checks 'enabled' flag.
>
> It generates spurious trace events if you enable them.
>
You mean the trace events from core.c? If it is, we could try to improve it
and indicate it is already enabled or disabled.
Peter
Powered by blists - more mailing lists