linux-kernel - [tip: irq/core] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159082479927.17951.3725006513982997123.tip-bot2@tip-bot2>
Date:   Sat, 30 May 2020 07:46:39 -0000
From:   "tip-bot2 for Wesley W. Terpstra" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Atish Patra <atish.patra@....com>,
        "Wesley W. Terpstra" <wesley@...ive.com>,
        Marc Zyngier <maz@...nel.org>,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        x86 <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: [tip: irq/core] irqchip/sifive-plic: Remove incorrect requirement
 about number of irq contexts

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     82f2202ddc97490994fad0dbfec04a014fa5163d
Gitweb:        https://git.kernel.org/tip/82f2202ddc97490994fad0dbfec04a014fa5163d
Author:        Wesley W. Terpstra <wesley@...ive.com>
AuthorDate:    Tue, 12 May 2020 10:26:36 -07:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Mon, 18 May 2020 10:28:30 +01:00

irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts

A PLIC may not be connected to all the cores. In that case, nr_contexts
may be less than num_possible_cpus. This requirement is only valid a single
PLIC is the only interrupt controller for the whole system.

Signed-off-by: Atish Patra <atish.patra@....com>
Signed-off-by: "Wesley W. Terpstra" <wesley@...ive.com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
Link: https://lore.kernel.org/r/20200512172636.96299-1-atish.patra@wdc.com

[Atish: Modified the commit text]
---
 drivers/irqchip/irq-sifive-plic.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index d0a71fe..822e074 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -301,8 +301,6 @@ static int __init plic_init(struct device_node *node,
 	nr_contexts = of_irq_count(node);
 	if (WARN_ON(!nr_contexts))
 		goto out_iounmap;
-	if (WARN_ON(nr_contexts < num_possible_cpus()))
-		goto out_iounmap;
 
 	error = -ENOMEM;
 	priv->irqdomain = irq_domain_add_linear(node, nr_irqs + 1,