linux-kernel - Re: [PATCH v4 1/2] remoteproc: qcom: Add per subsystem SSR notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 May 2020 18:30:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Rishabh Bhatnagar <rishabhb@...eaurora.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, bjorn.andersson@...aro.org,
        tsoni@...eaurora.org, psodagud@...eaurora.org,
        sidgup@...eaurora.org, Rishabh Bhatnagar <rishabhb@...eaurora.org>
Subject: Re: [PATCH v4 1/2] remoteproc: qcom: Add per subsystem SSR
 notification

Hi Rishabh,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20200526]
[also build test WARNING on v5.7-rc7]
[cannot apply to linus/master linux/master v5.7-rc7 v5.7-rc6 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Rishabh-Bhatnagar/Extend-SSR-notifications-framework/20200528-115948
base:    b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/remoteproc/qcom_common.c:200:28: warning: no previous prototype for 'qcom_ssr_get_subsys' [-Wmissing-prototypes]
200 | struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
|                            ^~~~~~~~~~~~~~~~~~~

vim +/qcom_ssr_get_subsys +200 drivers/remoteproc/qcom_common.c

   199	
 > 200	struct qcom_ssr_subsystem *qcom_ssr_get_subsys(const char *name)
   201	{
   202		struct qcom_ssr_subsystem *info;
   203	
   204		/* Match in the global qcom_ssr_subsystem_list with name */
   205		list_for_each_entry(info, &qcom_ssr_subsystem_list, list) {
   206			if (!strcmp(info->name, name))
   207				return info;
   208		}
   209		info = kzalloc(sizeof(*info), GFP_KERNEL);
   210		if (!info)
   211			return ERR_PTR(-ENOMEM);
   212		info->name = kstrdup_const(name, GFP_KERNEL);
   213		srcu_init_notifier_head(&info->notifier_list);
   214	
   215		/* Add to global notif list */
   216		INIT_LIST_HEAD(&info->list);
   217		list_add_tail(&info->list, &qcom_ssr_subsystem_list);
   218	
   219		return info;
   220	}
   221	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (72782 bytes)