linux-kernel - Re: [PATCH] checkpatch/coding-style: Allow 100 column lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a45357fe-6570-ef20-ed0e-494cdf7a6f1d@web.de>
Date:   Sat, 30 May 2020 13:40:53 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Joe Perches <joe@...ches.com>, kernel-janitors@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        netfilter-devel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        Casey Schaufler <casey@...aufler-ca.com>,
        Christoph Hellwig <hch@....de>,
        David Howells <dhowells@...hat.com>,
        David Laight <David.Laight@...LAB.COM>,
        Ian Kent <raven@...maw.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] checkpatch/coding-style: Allow 100 column lines

> Change the maximum allowed line length to 100 from 80.
>
> Miscellanea:
>
> o to avoid unnecessary whitespace changes in files,
>   checkpatch will no longer emit a warning about line length
>   when scanning files unless --strict is also used
> o Add a bit to coding-style about alignment to open parenthesis

I suggest to convert this patch into a patch series with three update steps.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=86852175b016f0c6873dcbc24b93d12b7b246612#n138


…
> +++ b/Documentation/process/coding-style.rst
> @@ -84,15 +84,22 @@ …
…
> +… and are
> +are placed …

Please avoid a word duplication here.


> +… to a function open parenthesis.

Wording alternatives:

+is to align descendants to an open parenthesis of a function call.


> +These same rules are …

+The same rules are applied to function headers with a long argument list.


Regards,
Markus