linux-kernel - RE: [PATCH v3] virtio_vsock: Fix race condition in virtio_transport_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR08MB4069DA3BA6B5F59094E2CCBAF78C0@AM6PR08MB4069.eurprd08.prod.outlook.com>
Date:   Sat, 30 May 2020 12:26:33 +0000
From:   Justin He <Justin.He@....com>
To:     Markus Elfring <Markus.Elfring@....de>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Kaly Xin <Kaly.Xin@....com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Stefano Garzarella <sgarzare@...hat.com>
Subject: RE: [PATCH v3] virtio_vsock: Fix race condition in
 virtio_transport_recv_pkt()

Hi Markus

> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@....de>
> Sent: Saturday, May 30, 2020 6:41 PM
> To: Justin He <Justin.He@....com>; kvm@...r.kernel.org;
> netdev@...r.kernel.org; virtualization@...ts.linux-foundation.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org;
> stable@...r.kernel.org; David S. Miller <davem@...emloft.net>; Jakub
> Kicinski <kuba@...nel.org>; Kaly Xin <Kaly.Xin@....com>; Stefan Hajnoczi
> <stefanha@...hat.com>; Stefano Garzarella <sgarzare@...hat.com>
> Subject: Re: [PATCH v3] virtio_vsock: Fix race condition in
> virtio_transport_recv_pkt()
>
> > This fixes it by checking sk->sk_shutdown(suggested by Stefano) after
> > lock_sock since sk->sk_shutdown is set to SHUTDOWN_MASK under the
> > protection of lock_sock_nested.
>
> How do you think about a wording variant like the following?
>
>   Thus check the data structure member “sk_shutdown” (suggested by Stefano)
>   after a call of the function “lock_sock” since this field is set to
>   “SHUTDOWN_MASK” under the protection of “lock_sock_nested”.
>
Okay, will update the commit msg.

>
> Would you like to add the tag “Fixes” to the commit message?
Sure.

Thanks


--
Cheers,
Justin (Jia He)


>
> Regards,
> Markus
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.