linux-kernel - Re: [PATCH 2/2] irqchip: loongson-*: Fix COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 May 2020 14:09:45 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     kbuild test robot <lkp@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Huacai Chen <chenhc@...ote.com>, linux-kernel@...r.kernel.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH 2/2] irqchip: loongson-*: Fix COMPILE_TEST

On Sat, 30 May 2020 13:11:13 +0100,
Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
> 
> spurious_interrupt helper only exists on MIPS and x86,
> so define a dummy function on other architectures to fix
> COMPILE_TEST.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> ---
>  drivers/irqchip/irq-loongson-htpic.c   | 4 ++++
>  drivers/irqchip/irq-loongson-htvec.c   | 4 ++++
>  drivers/irqchip/irq-loongson-liointc.c | 4 ++++
>  3 files changed, 12 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-loongson-htpic.c b/drivers/irqchip/irq-loongson-htpic.c
> index dd018c22ea83..7f38fdb2cb43 100644
> --- a/drivers/irqchip/irq-loongson-htpic.c
> +++ b/drivers/irqchip/irq-loongson-htpic.c
> @@ -26,6 +26,10 @@ struct loongson_htpic {
>  
>  static struct loongson_htpic *htpic;
>  
> +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86)
> +static inline void spurious_interrupt(void) { }
> +#endif

No, that's really horrible, and it doesn't scale. Dropping the
COMPILE_TEST dependency is cleaner, and we should look into having a
common framework across architectures to account for spurious
interrupts.

Not to mention that the HTPIC is not compiled with COMPILE_TEST anyway.

> +
>  static void htpic_irq_dispatch(struct irq_desc *desc)
>  {
>  	struct loongson_htpic *priv = irq_desc_get_handler_data(desc);
> diff --git a/drivers/irqchip/irq-loongson-htvec.c b/drivers/irqchip/irq-loongson-htvec.c
> index 1ece9337c78d..03c3973d7525 100644
> --- a/drivers/irqchip/irq-loongson-htvec.c
> +++ b/drivers/irqchip/irq-loongson-htvec.c
> @@ -33,6 +33,10 @@ struct htvec {
>  	raw_spinlock_t		htvec_lock;
>  };
>  
> +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86)
> +static inline void spurious_interrupt(void) { }
> +#endif

I've already addressed this by dropping COMPILE_TEST.

> +
>  static void htvec_irq_dispatch(struct irq_desc *desc)
>  {
>  	int i;
> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
> index 63b61474a0cc..e31744e2d800 100644
> --- a/drivers/irqchip/irq-loongson-liointc.c
> +++ b/drivers/irqchip/irq-loongson-liointc.c
> @@ -46,6 +46,10 @@ struct liointc_priv {
>  	bool				has_lpc_irq_errata;
>  };
>  
> +#if !defined(CONFIG_MIPS) && !defined(CONFIG_X86)
> +static inline void spurious_interrupt(void) { }
> +#endif

Neither is this one.

	M.

-- 
Without deviation from the norm, progress is not possible.