linux-kernel - Re: [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow in debiirq()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e9624d66-5466-7b7d-4fb9-af73b995e7f2@web.de>
Date:   Sat, 30 May 2020 17:27:48 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Jia-Ju Bai <baijiaju@...nghua.edu.cn>, linux-media@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sean Young <sean@...s.org>
Subject: Re: [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow
 in debiirq()

> To fix this possible bug, data[0] is assigned to a local variable, which
> replaces the use of data[0].

How do you think about a wording variant like the following?

  Thus assign the first element of the data array to a local variable
  so that it can be used as an array index together with the data structure
  member “ci_slot” in a safer way.

Would you like to add the tag “Fixes” to the commit message?
Are you going to take this possibility into account for any more patches?

Regards,
Markus