[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <5ed39ad2.0a1dg5gg0oNfWJPp%lkp@intel.com>
Date: Sun, 31 May 2020 19:53:54 +0800
From: kernel test robot <lkp@...el.com>
To: "Peter, Zijlstra," <peterz@...radead.org>
Cc: LKP <lkp@...ts.01.org>, linux-kernel@...r.kernel.org,
x86@...nel.org, linux-kernel@...r.kernel.org,
"Thomas, Gleixner," <tglx@...utronix.de>, philip.li@...el.com
Subject: b614345f52 ("x86/entry: Clarify irq_{enter,exit}_rcu()"):
WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:3680
lockdep_hardirqs_on_prepare
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/entry
commit b614345f52bcde8299a53132f5e48a9eb5a1f320
Author: Peter Zijlstra <peterz@...radead.org>
AuthorDate: Fri May 29 23:27:39 2020 +0200
Commit: Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sat May 30 10:00:10 2020 +0200
x86/entry: Clarify irq_{enter,exit}_rcu()
Because:
irq_enter_rcu() includes lockdep_hardirq_enter()
irq_exit_rcu() does *NOT* include lockdep_hardirq_exit()
Which resulted in two 'stray' lockdep_hardirq_exit() calls in
idtentry.h, and me spending a long time trying to find the matching
enter calls.
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Link: https://lkml.kernel.org/r/20200529213321.359433429@infradead.org
0f81407e6e x86/entry: Remove DBn stacks
b614345f52 x86/entry: Clarify irq_{enter,exit}_rcu()
5980d208e5 x86/idt: Consolidate idt functionality
+--------------------------------------------------------------------------------------+------------+------------+------------+
| | 0f81407e6e | b614345f52 | 5980d208e5 |
+--------------------------------------------------------------------------------------+------------+------------+------------+
| boot_successes | 37 | 0 | 0 |
| boot_failures | 2 | 13 | 343 |
| Kernel_panic-not_syncing:VFS:Unable_to_mount_root_fs_on_unknown-block(#,#) | 2 | | |
| WARNING:at_kernel/locking/lockdep.c:#lockdep_hardirqs_on_prepare | 0 | 13 | 342 |
| RIP:lockdep_hardirqs_on_prepare | 0 | 13 | 342 |
| RIP:default_idle | 0 | 13 | 338 |
| RIP:__do_softirq | 0 | 0 | 5 |
| RIP:_raw_spin_unlock_irqrestore | 0 | 0 | 1 |
| RIP:_raw_spin_unlock_irq | 0 | 0 | 4 |
| BUG:unable_to_handle_page_fault_for_address | 0 | 0 | 2 |
| BUG:kernel_hang_in_test_stage | 0 | 0 | 4 |
| WARNING:at_fs/read_write.c:#vfs_copy_file_range | 0 | 0 | 1 |
| RIP:vfs_copy_file_range | 0 | 0 | 1 |
| INFO:rcu_preempt_self-detected_stall_on_CPU | 0 | 0 | 1 |
| RIP:iov_iter_copy_from_user_atomic | 0 | 0 | 1 |
| RIP:bvec_iter_advance | 0 | 0 | 1 |
| RIP:rcu_check_gp_start_stall | 0 | 0 | 1 |
| BUG:kernel_hang_in_early-boot_stage,last_printk:Probing_EDD(edd=off_to_disable)...ok | 0 | 0 | 1 |
| INFO:rcu_preempt_detected_stalls_on_CPUs/tasks | 0 | 0 | 1 |
| RIP:___might_sleep | 0 | 0 | 1 |
| RIP:arch_local_save_flags | 0 | 0 | 1 |
| RIP:fgraph_trace | 0 | 0 | 1 |
+--------------------------------------------------------------------------------------+------------+------------+------------+
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <lkp@...el.com>
[ 0.429563] smp: Brought up 1 node, 2 CPUs
[ 0.430121] smpboot: Max logical packages: 2
[ 0.430717] smpboot: Total of 2 processors activated (9199.98 BogoMIPS)
[ 0.432170] ------------[ cut here ]------------
[ 0.432830] DEBUG_LOCKS_WARN_ON(current->hardirq_context)
[ 0.432855] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:3680 lockdep_hardirqs_on_prepare+0xee/0x13f
[ 0.434909] Modules linked in:
[ 0.435334] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.7.0-rc5-00398-gb614345f52bcd #1
[ 0.435551] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
[ 0.435551] RIP: 0010:lockdep_hardirqs_on_prepare+0xee/0x13f
[ 0.435551] Code: 00 00 00 74 29 e8 fb 41 90 00 85 c0 74 6a 83 3d a6 75 d3 01 00 75 61 48 c7 c6 aa 0a 92 82 48 c7 c7 09 ac 90 82 e8 de 2d fb ff <0f> 0b eb 4a 65 48 8b 2c 25 c0 23 01 00 48 8b 85 d8 08 00 00 ff 85
[ 0.435551] RSP: 0000:ffffffff82c03de0 EFLAGS: 00010082
[ 0.435551] RAX: 000000000000002d RBX: 0000000000000001 RCX: 00000000000000de
[ 0.435551] RDX: ffffffff82c188c0 RSI: ffffffff82e6f9c0 RDI: ffffffff81144e31
[ 0.435551] RBP: ffffffff82c03e08 R08: 0000000019cc7922 R09: 000000000000002d
[ 0.435551] R10: 0000000000000000 R11: 0000000000000018 R12: 0000000000000000
[ 0.435551] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[ 0.435551] FS: 0000000000000000(0000) GS:ffff88823fa00000(0000) knlGS:0000000000000000
[ 0.435551] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.435551] CR2: 00000000ffffffff CR3: 0000000002c11001 CR4: 00000000001606b0
[ 0.435551] Call Trace:
[ 0.435551] idtentry_exit_cond_rcu+0x78/0xc6
[ 0.435551] asm_sysvec_reschedule_ipi+0x12/0x20
[ 0.435551] RIP: 0010:default_idle+0x22/0x31
[ 0.435551] Code: ff cc cc cc cc cc cc cc e8 93 f4 5d ff e8 0c 41 ff ff bf 01 00 00 00 89 c6 e8 2a 5b 5c ff e8 63 11 76 ff e8 04 5a 5c ff fb f4 <e8> ef 40 ff ff 83 cf ff 89 c6 e9 0f 5b 5c ff e8 62 f4 5d ff 53 65
[ 0.435551] RSP: 0000:ffffffff82c03eb0 EFLAGS: 00000202
[ 0.435551] RAX: 0000000000001631 RBX: ffffffff82c188c0 RCX: 0000000019c0f324
[ 0.435551] RDX: ffffffff82c188c0 RSI: 0000000000000006 RDI: ffffffff81a4b813
[ 0.435551] RBP: 0000000000000000 R08: 0000000019c0f439 R09: 00000000000c0025
[ 0.435551] R10: 0000000000000000 R11: 0000000000000002 R12: 0000000000000000
[ 0.435551] R13: 0000000000000000 R14: 0000000000000000 R15: ffff88807ffff1b3
[ 0.435551] ? default_idle+0x1b/0x31
[ 0.435551] default_idle_call+0x1f/0x24
[ 0.435551] do_idle+0xba/0x1a2
[ 0.435551] cpu_startup_entry+0x1d/0x1f
[ 0.435551] start_kernel+0x62c/0x63b
[ 0.435551] ? copy_bootdata+0x18/0x55
[ 0.435551] secondary_startup_64+0xb6/0xc0
[ 0.435551] irq event stamp: 5682
[ 0.435551] hardirqs last enabled at (5681): [<ffffffff81a4b813>] default_idle+0x1b/0x31
[ 0.435551] hardirqs last disabled at (5682): [<ffffffff81a3e568>] sysvec_reschedule_ipi+0x10/0x206
[ 0.435551] softirqs last enabled at (5622): [<ffffffff8101249a>] fpregs_unlock+0x0/0x2c
[ 0.435551] softirqs last disabled at (5620): [<ffffffff8101239b>] fpregs_lock+0x0/0x1b
[ 0.435551] ---[ end trace 16c55d73b2811f58 ]---
[ 0.471573] node 0 initialised, 1245092 pages in 32ms
# HH:MM RESULT GOOD BAD GOOD_BUT_DIRTY DIRTY_NOT_BAD
git bisect start 5980d208e5ef28455e9e8b08f6250b443a2f0893 5a7462b1f9c19312da0e489b859184cc88229bad --
git bisect good ff98610a03285516b578821549973f969118d6a3 # 09:49 G 10 0 0 0 x86/entry, mce: Disallow #DB during #MC
git bisect bad 029149180d1d6e05e81e7db0d46c00960ab2e84f # 10:04 B 0 2 18 0 x86/entry: Rename trace_hardirqs_off_prepare()
git bisect good 8449e768dcb85b4d8db51482d8c9260bb05ccabc # 16:10 G 11 0 0 0 x86/entry: Remove debug IDT frobbing
git bisect good 0f81407e6e4cf7e878f1e5d6423324dbd966acba # 16:39 G 10 0 0 0 x86/entry: Remove DBn stacks
git bisect bad b614345f52bcde8299a53132f5e48a9eb5a1f320 # 18:12 B 0 3 19 0 x86/entry: Clarify irq_{enter,exit}_rcu()
# first bad commit: [b614345f52bcde8299a53132f5e48a9eb5a1f320] x86/entry: Clarify irq_{enter,exit}_rcu()
git bisect good 0f81407e6e4cf7e878f1e5d6423324dbd966acba # 18:21 G 31 0 0 2 x86/entry: Remove DBn stacks
# extra tests with debug options
git bisect bad b614345f52bcde8299a53132f5e48a9eb5a1f320 # 18:41 B 0 6 22 0 x86/entry: Clarify irq_{enter,exit}_rcu()
# extra tests on head commit of tip/x86/entry
git bisect bad 5980d208e5ef28455e9e8b08f6250b443a2f0893 # 18:58 B 0 342 362 1 x86/idt: Consolidate idt functionality
# bad: [5980d208e5ef28455e9e8b08f6250b443a2f0893] x86/idt: Consolidate idt functionality
# extra tests on revert first bad commit
git bisect good 375bc8902bee1ddc5098b9063d15956aef8ebf18 # 19:48 G 10 0 0 0 Revert "x86/entry: Clarify irq_{enter,exit}_rcu()"
# good: [375bc8902bee1ddc5098b9063d15956aef8ebf18] Revert "x86/entry: Clarify irq_{enter,exit}_rcu()"
# extra tests on tip/master
# 119: [14bf8733b3c1887abab08371c47e68f2afbc0b93] Merge branch 'x86/urgent'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/lkp@lists.01.org
Download attachment "dmesg-yocto-vm-yocto-19:20200531181319:x86_64-randconfig-c002-20200529:5.7.0-rc5-00398-gb614345f52bcd:1.gz" of type "application/gzip" (19633 bytes)
Download attachment "dmesg-vm-snb-56:20200531164551:x86_64-randconfig-c002-20200529:5.7.0-rc5-00397-g0f81407e6e4cf:1.gz" of type "application/gzip" (16082 bytes)
View attachment "reproduce-yocto-vm-yocto-19:20200531181319:x86_64-randconfig-c002-20200529:5.7.0-rc5-00398-gb614345f52bcd:1" of type "text/plain" (934 bytes)
Download attachment "5980d208e5ef28455e9e8b08f6250b443a2f0893:gcc-9:x86_64-randconfig-c002-20200529:WARNING:at_kernel_locking_lockdep.c:_lockdep_hardirqs_on_prepare.xz" of type "application/x-xz" (7304 bytes)
View attachment "config-5.7.0-rc5-00398-gb614345f52bcd" of type "text/plain" (148392 bytes)
View attachment "config-5.7.0-rc5-00398-gb614345f52bcd" of type "text/plain" (148393 bytes)
Powered by blists - more mailing lists