linux-kernel - Re: [PATCH 5/6] iio: light: stk3310: Constify regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 May 2020 14:47:55 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Rikard Falkeborn <rikard.falkeborn@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] iio: light: stk3310: Constify regmap_config

On Tue, 26 May 2020 23:02:22 +0200
Rikard Falkeborn <rikard.falkeborn@...il.com> wrote:

> stk3310_regmap_config is not modified and can be made const to allow the
> compiler to put it in read-only memory.
> 
> Before:
>    text    data     bss     dec     hex filename
>   16027    5424     128   21579    544b drivers/iio/light/stk3310.o
> 
> After:
>    text    data     bss     dec     hex filename
>   16347    5104     128   21579    544b drivers/iio/light/stk3310.o
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
Applied.

thanks,

Jonathan

> ---
>  drivers/iio/light/stk3310.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> index 185c24a75ae6..9d1e503bc958 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -487,7 +487,7 @@ static bool stk3310_is_volatile_reg(struct device *dev, unsigned int reg)
>  	}
>  }
>  
> -static struct regmap_config stk3310_regmap_config = {
> +static const struct regmap_config stk3310_regmap_config = {
>  	.name = STK3310_REGMAP_NAME,
>  	.reg_bits = 8,
>  	.val_bits = 8,