linux-kernel - Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200531154017.04fc727f@archlinux>
Date:   Sun, 31 May 2020 15:40:17 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <nicolas.ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <ludovic.desroches@...rochip.com>
Subject: Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to
 driver

On Mon, 25 May 2020 13:27:44 +0300
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> Since changes can come from all sort of places, it may make sense to have
> this symbol as a dependency to make sure that the 'make allmodconfig' &&
> 'make allyesconfig' build rules cover this driver as well for a
> compile-build/test.
> 
> It seemed useful [recently] when trying to apply a change for this.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Makes sense.   Given this sort of change can expose weird an wonderful
dependencies that were previously hidden, I'll be wanting an
ack from at91 people.

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index c48c00077775..c1f4c0aec265 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -294,7 +294,7 @@ config ASPEED_ADC
>  
>  config AT91_ADC
>  	tristate "Atmel AT91 ADC"
> -	depends on ARCH_AT91
> +	depends on ARCH_AT91 || COMPILE_TEST
>  	depends on INPUT && SYSFS
>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER