linux-kernel - Re: [PATCH] staging:r8723bs: remove wrappers around skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 May 2020 10:36:59 -0700
From:   Joe Perches <joe@...ches.com>
To:     Ivan Safonov <insafonov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Rasmus Villemoes <linux@...musvillemoes.dk>,
        Hans de Goede <hdegoede@...hat.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        Lukasz Szczesny <luk@...cz.pl>, R Veera Kumar <vkor@...en.in>,
        Hariprasad Kelam <hariprasad.kelam@...il.com>,
        YueHaibing <yuehaibing@...wei.com>,
        Shobhit Kukreti <shobhitkukreti@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Pascal Terjan <pterjan@...gle.com>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:r8723bs: remove wrappers around skb_clone()

On Sun, 2020-05-31 at 20:28 +0300, Ivan Safonov wrote:
> On 5/31/20 7:15 PM, Joe Perches wrote:
> > On Sun, 2020-05-31 at 19:08 +0300, Ivan Safonov wrote:
> > > Wrappers around skb_clone() do not simplify the driver code.
> > []
> > > -inline struct sk_buff *_rtw_skb_clone(struct sk_buff *skb)
> > > -{
> > > -	return skb_clone(skb, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
> > > -}
> > > -
> > []
> > > diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
> > []
> > > @@ -110,7 +110,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, _pkt *pkt, struct rx_pkt
> > >   			if (memcmp(pattrib->dst, myid(&padapter->eeprompriv), ETH_ALEN)) {
> > >   				if (bmcast) {
> > >   					psta = rtw_get_bcmc_stainfo(padapter);
> > > -					pskb2 = rtw_skb_clone(pkt);
> > > +					pskb2 = skb_clone(pkt, GFP_ATOMIC);
> > 
> > Why make every clone allocation GFP_ATOMIC ?
> 
> The rtw_os_recv_indicate_pkt() is always called from an interrupt handler.

It'd be better to indicate you know that in the changelog
as the subject and changelog just shows removing wrappers
and the patch code does not agree with that.