lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 31 May 2020 08:41:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lokesh Chebrolu <lokeshch007@...il.com>
Cc:     hadess@...ess.net, stern@...land.harvard.edu,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: usb: core: driver: fixed 80 line character
 length issue

On Sun, May 31, 2020 at 07:20:06AM +0530, Lokesh Chebrolu wrote:
> From: lokeshch007 <lokeshch007@...il.com>

This has to match the s-o-b line

> 
> Fixed a coding style issue

What issue?


> 
> Signed-off-by: Lokesh Chebrolu <lokeshch007@...il.com>
> ---
>  drivers/usb/core/driver.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> index f81606c..83c3287 100644
> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
> @@ -1796,7 +1796,9 @@ int usb_autopm_get_interface_async(struct usb_interface *intf)
>  EXPORT_SYMBOL_GPL(usb_autopm_get_interface_async);
>  
>  /**
> - * usb_autopm_get_interface_no_resume - increment a USB interface's PM-usage counter
> + * usb_autopm_get_interface_no_resume -
> + * increment a USB interface's PM-usage counter
> + *

Nope, the original is correct, sorry, kerneldoc wants this to be a long
single line.

When starting out in kernel development, please stick to
drivers/staging/ which has lots of places to clean up and patches like
this are welcomed much more so than other parts of the kernel.

thanks,

greg k-h

Powered by blists - more mailing lists