lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 May 2020 09:01:38 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Dinghao Liu <dinghao.liu@....edu.cn>, kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org, linux-imx@....com Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Dong Aisheng <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>, Kangjie Lu <kjlu@....edu>, Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org> Subject: Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable() > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. * How do you think about to replace the word “pairing” by “corresponding”? * Will it be helpful to add an imperative wording? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ffeb595d84811dde16a28b33d8a7cf26d51d51b3#n151 * Would you like to add the tag “Fixes” to the commit message? * Are you going to take such possibilities into account for any more patches? Regards, Markus
Powered by blists - more mailing lists