lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 May 2020 10:38:04 +0200
From:   Geert Uytterhoeven <>
To:     Finn Thain <>
Cc:     Benjamin Herrenschmidt <>,
        Joshua Thompson <>,
        linux-m68k <>,
        Linux Kernel Mailing List <>,
        linuxppc-dev <>
Subject: Re: [PATCH 8/8] macintosh/adb-iop: Implement SRQ autopolling

Hi Finn,

On Sun, May 31, 2020 at 1:20 AM Finn Thain <> wrote:
> The adb_driver.autopoll method is needed during ADB bus scan and device
> address assignment. Implement this method so that the IOP's list of
> device addresses can be updated. When the list is empty, disable SRQ
> autopolling.
> Cc: Joshua Thompson <>
> Cc: Geert Uytterhoeven <>
> Tested-by: Stan Johnson <>
> Signed-off-by: Finn Thain <>

Thanks for your patch!

Acked-by: Geert Uytterhoeven <>

>  arch/m68k/include/asm/adb_iop.h |  1 +
>  drivers/macintosh/adb-iop.c     | 32 ++++++++++++++++++++++++++------

As this header file is used by a single source file only, perhaps it should
just be absorbed by the latter?
Then you no longer need my Acked-by for future changes ;-)



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists