linux-kernel - Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <286858ff.db7e3.17269ee5f3f.Coremail.dinghao.liu@zju.edu.cn>
Date:   Sun, 31 May 2020 16:52:09 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Markus Elfring" <Markus.Elfring@....de>
Cc:     dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Ben Skeggs" <bskeggs@...hat.com>,
        "David Airlie" <airlied@...ux.ie>, "Kangjie Lu" <kjlu@....edu>
Subject: Re: Re: drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

> 
> > For security, I will release this pointer only on error paths in this function.
> 
> Do you tend to release objects (which are referenced by pointers)?
> 

I just found that clk is referenced by pclk in this function. When clk is freed, 
pclk will be allocated in gm20b_clk_new_speedo0(). Thus we should not release clk
in this function and there is no bug here. Thank you for reminding me!

Regards,
Dinghao