linux-kernel - Re: [PATCH ghak124 v2] audit: log nftables configuration change events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202006010711.XsbeqYjc%lkp@intel.com>
Date:   Mon, 1 Jun 2020 07:38:07 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Richard Guy Briggs <rgb@...hat.com>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        netfilter-devel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Paul Moore <paul@...l-moore.com>,
        sgrubb@...hat.com, omosnace@...hat.com, fw@...len.de,
        twoerner@...hat.com, eparis@...isplace.org, tgraf@...radead.org
Subject: Re: [PATCH ghak124 v2] audit: log nftables configuration change
 events

Hi Richard,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pcmoore-audit/next]
[also build test ERROR on next-20200529]
[cannot apply to nf/master nf-next/master linus/master linux/master v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Richard-Guy-Briggs/audit-log-nftables-configuration-change-events/20200531-043244
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

In file included from arch/sparc/kernel/ptrace_64.c:25:
>> include/linux/audit.h:126:40: error: 'audit_nftcfgs' defined but not used [-Werror=unused-const-variable=]
126 | static const struct audit_nftcfgop_tab audit_nftcfgs[] = {
|                                        ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

vim +/audit_nftcfgs +126 include/linux/audit.h

   125	
 > 126	static const struct audit_nftcfgop_tab audit_nftcfgs[] = {
   127		{ NFT_MSG_NEWTABLE,	AUDIT_NFT_OP_TABLE_REGISTER		},
   128		{ NFT_MSG_GETTABLE,	AUDIT_NFT_OP_INVALID			},
   129		{ NFT_MSG_DELTABLE,	AUDIT_NFT_OP_TABLE_UNREGISTER		},
   130		{ NFT_MSG_NEWCHAIN,	AUDIT_NFT_OP_CHAIN_REGISTER		},
   131		{ NFT_MSG_GETCHAIN,	AUDIT_NFT_OP_INVALID			},
   132		{ NFT_MSG_DELCHAIN,	AUDIT_NFT_OP_CHAIN_UNREGISTER		},
   133		{ NFT_MSG_NEWRULE,	AUDIT_NFT_OP_RULE_REGISTER		},
   134		{ NFT_MSG_GETRULE,	AUDIT_NFT_OP_INVALID			},
   135		{ NFT_MSG_DELRULE,	AUDIT_NFT_OP_RULE_UNREGISTER		},
   136		{ NFT_MSG_NEWSET,	AUDIT_NFT_OP_SET_REGISTER		},
   137		{ NFT_MSG_GETSET,	AUDIT_NFT_OP_INVALID			},
   138		{ NFT_MSG_DELSET,	AUDIT_NFT_OP_SET_UNREGISTER		},
   139		{ NFT_MSG_NEWSETELEM,	AUDIT_NFT_OP_SETELEM_REGISTER		},
   140		{ NFT_MSG_GETSETELEM,	AUDIT_NFT_OP_INVALID			},
   141		{ NFT_MSG_DELSETELEM,	AUDIT_NFT_OP_SETELEM_UNREGISTER		},
   142		{ NFT_MSG_NEWGEN,	AUDIT_NFT_OP_GEN_REGISTER		},
   143		{ NFT_MSG_GETGEN,	AUDIT_NFT_OP_INVALID			},
   144		{ NFT_MSG_TRACE,	AUDIT_NFT_OP_INVALID			},
   145		{ NFT_MSG_NEWOBJ,	AUDIT_NFT_OP_OBJ_REGISTER		},
   146		{ NFT_MSG_GETOBJ,	AUDIT_NFT_OP_INVALID			},
   147		{ NFT_MSG_DELOBJ,	AUDIT_NFT_OP_OBJ_UNREGISTER		},
   148		{ NFT_MSG_GETOBJ_RESET,	AUDIT_NFT_OP_OBJ_RESET			},
   149		{ NFT_MSG_NEWFLOWTABLE,	AUDIT_NFT_OP_FLOWTABLE_REGISTER		},
   150		{ NFT_MSG_GETFLOWTABLE,	AUDIT_NFT_OP_INVALID			},
   151		{ NFT_MSG_DELFLOWTABLE,	AUDIT_NFT_OP_FLOWTABLE_UNREGISTER	},
   152		{ NFT_MSG_MAX,		AUDIT_NFT_OP_INVALID			},
   153	};
   154	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (62442 bytes)