linux-kernel - Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a proper NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200601.110654.1178868171436999333.davem@davemloft.net>
Date:   Mon, 01 Jun 2020 11:06:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     patrickeigensatz@...il.com
Cc:     dsahern@...nel.org, nikolay@...ulusnetworks.com,
        scan-admin@...erity.com, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv4: nexthop: Fix deadcode issue by performing a
 proper NULL check

From: patrickeigensatz@...il.com
Date: Mon,  1 Jun 2020 13:12:01 +0200

> From: Patrick Eigensatz <patrickeigensatz@...il.com>
> 
> After allocating the spare nexthop group it should be tested for kzalloc()
> returning NULL, instead the already used nexthop group (which cannot be
> NULL at this point) had been tested so far.
> 
> Additionally, if kzalloc() fails, return ERR_PTR(-ENOMEM) instead of NULL.
> 
> Coverity-id: 1463885
> Reported-by: Coverity <scan-admin@...erity.com>
> Signed-off-by: Patrick Eigensatz <patrickeigensatz@...il.com>

Applied, thank you.