linux-kernel - afs: Improve exception handling in afs_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cc663a5-088d-4d26-34cd-c96e362c1eb2@web.de>
Date:   Mon, 1 Jun 2020 21:34:26 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     linux-afs@...ts.infradead.org, David Howells <dhowells@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: afs: Improve exception handling in afs_net_init()

Hello,

I have accidentally taken another look at the implementation of
the function “afs_net_init”.
I noticed that the statement “net->live = false;” was specified three times
for exception handling at the end.
https://elixir.bootlin.com/linux/v5.7/source/fs/afs/main.c#L127
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/afs/main.c?id=9bf9511e3d9f328c03f6f79bfb741c3d18f2f2c0#n127

Can it be that two of these assignments are redundant then?

Regards,
Markus