linux-kernel - Re: [2/2] Coccinelle: memdup_user: Extending data processing for special tokens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6cd81cb9-7fb6-bddc-65df-c3d50677ae7d@web.de>
Date:   Mon, 1 Jun 2020 07:47:52 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Denis Efremov <efremov@...ux.com>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Coccinelle <cocci@...teme.lip6.fr>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Joe Perches <joe@...ches.com>
Subject: Re: [2/2] Coccinelle: memdup_user: Extending data processing for
 special tokens

> Unfortunately, the Coccinelle software does not like the following
> SmPL code variant so far.
>
>  to =
> (
> -     \( kmalloc \| kzalloc \)
> +     memdup_user
> |
> -     \( kvmalloc \| kvzalloc \)
> +     vmemdup_user
> )
>                  (
> -                 size, \( GFP_KERNEL \| GFP_USER \)
> +                 from, size
>                  );
>
>
> Message:
> 25: no available token to attach to

I have adjusted a bit of OCaml source code.
Thus I could see where such information was provided.
https://github.com/coccinelle/coccinelle/blob/7cf2c23e64066d5249a64a316cc5347831f7a63f/parsing_cocci/insert_plus.ml#L1041

…
  | (((infop,count,pcode) as p) :: ps) as all ->
      (* …
	 modifications.  for the moment, we thus give an error, asking the
	 user to rewrite the semantic patch. *)
      if greater_than_end infop infom1 || is_minus m1 || !empty_isos
…


Will the referenced comment get any more software development attention?

Regards,
Markus