linux-kernel - Re: [PATCH] bpf: Change kvfree to kfree in generic_map_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Jun 2020 13:17:53 -0700
From:   Song Liu <song@...nel.org>
To:     Denis Efremov <efremov@...ux.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bpf: Change kvfree to kfree in generic_map_lookup_batch()

On Mon, Jun 1, 2020 at 9:29 AM Denis Efremov <efremov@...ux.com> wrote:
>
> buf_prevkey in generic_map_lookup_batch() is allocated with
> kmalloc(). It's safe to free it with kfree().
>
> Signed-off-by: Denis Efremov <efremov@...ux.com>

Please add prefix "PATCH bpf" or "PATCH bpf-next" to indicate which
tree this should
apply to. This one looks more like for bpf-next, as current code still
works. For patches
to bpf-next, we should wait after the merge window.

Also, maybe add:

Fixes: cb4d03ab499d ("bpf: Add generic support for lookup batch op")

Acked-by: Song Liu <songliubraving@...com>

Thanks,
Song