linux-kernel - Re: [PATCH net-next] tipc: Fix NULL pointer dereference in __tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200601.153522.370467432528991344.davem@davemloft.net>
Date:   Mon, 01 Jun 2020 15:35:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     jmaloy@...hat.com, ying.xue@...driver.com, kuba@...nel.org,
        tuong.t.lien@...tech.com.au, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] tipc: Fix NULL pointer dereference in
 __tipc_sendstream()

From: YueHaibing <yuehaibing@...wei.com>
Date: Thu, 28 May 2020 22:34:07 +0800

> tipc_sendstream() may send zero length packet, then tipc_msg_append()
> do not alloc skb, skb_peek_tail() will get NULL, msg_set_ack_required
> will trigger NULL pointer dereference.
> 
> Reported-by: syzbot+8eac6d030e7807c21d32@...kaller.appspotmail.com
> Fixes: 0a3e060f340d ("tipc: add test for Nagle algorithm effectiveness")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

I spent some time reading this a few times and the Fixes: commit and
this change looks ok to me so I'm just going to apply this.

Thanks.