linux-kernel - Re: [PATCH RESEND v8 1/2] ACPI / APEI: Add support to notify the vendor specific HW errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202006010824.guesejGS%lkp@intel.com>
Date:   Mon, 1 Jun 2020 08:59:13 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Shiju Jose <shiju.jose@...wei.com>, linux-acpi@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        rjw@...ysocki.net, bp@...en8.de, james.morse@....com,
        helgaas@...nel.org, lenb@...nel.org, tony.luck@...el.com,
        dan.carpenter@...cle.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH RESEND v8 1/2] ACPI / APEI: Add support to notify the
 vendor specific HW errors

Hi Shiju,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[also build test WARNING on linus/master v5.7-rc7]
[cannot apply to pm/linux-next next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Shiju-Jose/ACPI-APEI-Add-support-to-notify-the-vendor-specific-HW-errors/20200601-003936
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/acpi/apei/ghes.c:210:5: warning: no previous prototype for function 'ghes_gdata_pool_init' [-Wmissing-prototypes]
int ghes_gdata_pool_init(void)
^
drivers/acpi/apei/ghes.c:210:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int ghes_gdata_pool_init(void)
^
static
1 warning generated.

vim +/ghes_gdata_pool_init +210 drivers/acpi/apei/ghes.c

   209	
 > 210	int ghes_gdata_pool_init(void)
   211	{
   212		unsigned long addr, len;
   213		int rc;
   214	
   215		ghes_gdata_pool = gen_pool_create(GHES_GDATA_POOL_MIN_ALLOC_ORDER, -1);
   216		if (!ghes_gdata_pool)
   217			return -ENOMEM;
   218	
   219		if (ghes_gdata_pool_size_request < GHES_GDATA_POOL_MIN_SIZE)
   220			ghes_gdata_pool_size_request = GHES_GDATA_POOL_MIN_SIZE;
   221	
   222		len = ghes_gdata_pool_size_request;
   223		addr = (unsigned long)vmalloc(PAGE_ALIGN(len));
   224		if (!addr)
   225			goto err_pool_alloc;
   226	
   227		vmalloc_sync_mappings();
   228	
   229		rc = gen_pool_add(ghes_gdata_pool, addr, PAGE_ALIGN(len), -1);
   230		if (rc)
   231			goto err_pool_add;
   232	
   233		return 0;
   234	
   235	err_pool_add:
   236		vfree((void *)addr);
   237	
   238	err_pool_alloc:
   239		gen_pool_destroy(ghes_gdata_pool);
   240	
   241		return -ENOMEM;
   242	}
   243	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73483 bytes)