linux-kernel - Re: [PATCH] power: supply: bq24190_charger.c: call pm_runtime_put in pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <35c8ecf5-c3d0-33a5-3bb5-f8dbbe88647c@web.de>
Date:   Mon, 1 Jun 2020 10:01:20 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-pm@...r.kernel.org
Cc:     Navid Emamdoost <emamd001@....edu>, linux-kernel@...r.kernel.org,
        Kangjie Lu <kjlu@....edu>, Qiushi Wu <wu000273@....edu>,
        Stephen McCamant <mccamant@...umn.edu>,
        Sebastian Reichel <sre@...nel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Dinghao Liu <dinghao.liu@....edu.cn>
Subject: Re: [PATCH] power: supply: bq24190_charger.c: call pm_runtime_put in
 pm_runtime_get_sync failed case

> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value call pm_runtime_put_autosuspend.

* I find the word “usage_count” questionable in this change description.

* Will the tag “Fixes” become relevant for the commit message?

* Can an other label be more helpful than “out”?

* Would you like to take another look at a related update suggestion
  like “power: supply: bq24190_charger: Fix runtime PM imbalance on error”?
  https://lore.kernel.org/linux-pm/20200525110540.6949-1-dinghao.liu@zju.edu.cn/
  https://lore.kernel.org/patchwork/patch/1246783/

Regards,
Markus