linux-kernel - Re: [PATCH] [v2] PCI: tegra: Fix runtime PM imbalance on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200601090536.GA4226@e121166-lin.cambridge.arm.com>
Date:   Mon, 1 Jun 2020 10:05:36 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Dinghao Liu <dinghao.liu@....edu.cn>, kjlu@....edu,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-tegra@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] PCI: tegra: Fix runtime PM imbalance on error

On Fri, May 29, 2020 at 08:05:18PM +0200, Thierry Reding wrote:
> On Thu, May 21, 2020 at 10:47:09AM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an error code. Thus a pairing decrement is needed on
> > the error handling path to keep the counter balanced.
> > 
> > Also, call pm_runtime_disable() when pm_runtime_get_sync() returns
> > an error code.
> > 
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  drivers/pci/controller/pci-tegra.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Acked-by: Thierry Reding <treding@...dia.com>

Applied to pci/tegra, thanks !

Lorenzo