linux-kernel - Re: [PATCH] misc: atmel-ssc: lock with mutex instead of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb9b1cb3-5b3f-f387-da45-71427a4383ed@web.de>
Date:   Mon, 1 Jun 2020 11:18:48 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        linux-arm-kernel@...ts.infradead.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH] misc: atmel-ssc: lock with mutex instead of spinlock

> Uninterruptible context is not needed in the driver and causes lockdep
> warning because of mutex taken in of_alias_get_id().

Was a spin lock taken?


> Convert the lock to mutex to avoid the issue.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus