linux-kernel - Re: [PATCH] afs: Fix memory leak in afs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8e5aa79-3f83-a5de-5aa8-7bd4a287646e@web.de>
Date:   Mon, 1 Jun 2020 13:18:18 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Zhihao Cheng <chengzhihao1@...wei.com>,
        linux-afs@...ts.infradead.org, linux-fsdevel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
        Yi Zhang <yi.zhang@...wei.com>
Subject: Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().

* I suggest to use the wording “reference counter”.

* Where did you notice a “memory leak” here?


> Besides, it would be better set net->sysnames
> to 'NULL' after net->sysnames being released if afs_put_sysnames()
> aims on an afs_sysnames object.

* Would you like to consider an adjustment for this information?

* How do you think about to add an imperative wording?

* Will the tag “Fixes” become relevant for the commit message?

Regards,
Markus