linux-kernel - Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bec05b7-78d3-fa36-134a-efbe977933e3@web.de>
Date:   Mon, 1 Jun 2020 14:00:48 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Zhihao Cheng <chengzhihao1@...wei.com>,
        linux-mtd@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Richard Weinberger <richard@....at>,
        Yi Zhang <yi.zhang@...wei.com>
Subject: Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating
 entries

> Fix some potential memory leaks in error handling branches while
> iterating xattr entries.

Such information is useful.

> For example, function ubifs_tnc_remove_ino()
> forgets to free pxent if it exists. Similar problems also exist in
> ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().

Can an other wording variant be a bit nicer?

I suggest to avoid the specification of duplicate function calls
(also for the desired exception handling).
Will it be helpful to add a few jump targets?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455

Regards,
Markus