linux-kernel - [PATCH 0/6] leds: fix broken devres usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200601133950.12420-1-johan@kernel.org>
Date:   Mon,  1 Jun 2020 15:39:44 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>
Cc:     Dan Murphy <dmurphy@...com>,
        Amitoj Kaur Chawla <amitoj1606@...il.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Johan Hovold <johan@...nel.org>
Subject: [PATCH 0/6] leds: fix broken devres usage

Several MFD child drivers register their class devices directly under
the parent device (about half of the MFD LED drivers do so).

This means you cannot blindly do devres conversions so that
deregistration ends up being tied to the parent device, something which
leads to use-after-free on driver unbind when the class device is
released while still being registered (and, for example, oopses on later
parent MFD driver unbind or LED class callbacks, or resource leaks and
name clashes on child driver reload).

Included is also a clean up removing some pointless casts when
registering class devices.

All but the lm3533 one have only been compile tested.

Johan

Johan Hovold (6):
  leds: 88pm860x: fix use-after-free on unbind
  leds: da903x: fix use-after-free on unbind
  leds: lm3533: fix use-after-free on unbind
  leds: lm36274: fix use-after-free on unbind
  leds: wm831x-status: fix use-after-free on unbind
  leds: drop redundant struct-device pointer casts

 drivers/leds/leds-88pm860x.c      | 14 +++++++++++++-
 drivers/leds/leds-da903x.c        | 14 +++++++++++++-
 drivers/leds/leds-lm3533.c        | 12 +++++++++---
 drivers/leds/leds-lm355x.c        |  9 +++------
 drivers/leds/leds-lm36274.c       | 15 ++++++++++++---
 drivers/leds/leds-lm3642.c        |  9 +++------
 drivers/leds/leds-wm831x-status.c | 14 +++++++++++++-
 7 files changed, 66 insertions(+), 21 deletions(-)

-- 
2.26.2