linux-kernel - Re: [PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200601155204.hsatjbukj6haxhld@mobilestation>
Date:   Mon, 1 Jun 2020 18:52:04 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
        Paul Burton <paul.burton@...tec.com>,
        Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        James Hogan <jhogan@...nel.org>, <linux-mips@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] MAINTAINERS: Add maintainers for MIPS core drivers

On Mon, Jun 01, 2020 at 06:30:22PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 1, 2020 at 6:19 PM Serge Semin
> <Sergey.Semin@...kalelectronics.ru> wrote:
> > On Mon, Jun 01, 2020 at 04:56:21PM +0300, Andy Shevchenko wrote:
> > > On Mon, Jun 1, 2020 at 3:26 PM Serge Semin
> > > <Sergey.Semin@...kalelectronics.ru> wrote:
> > > >
> > > > Add myself as a maintainer of MIPS CPU and GIC IRQchip, MIPS GIC timer
> > > > and MIPS CPS CPUidle drivers.
> > > ...
> > > > +MIPS CORE DRIVERS
> > > > +M:     Serge Semin <fancer.lancer@...il.com>
> > > > +L:     linux-mips@...r.kernel.org
> > > > +S:     Supported
> > > > +F:     drivers/bus/mips_cdmm.c
> > > > +F:     drivers/irqchip/irq-mips-cpu.c
> > > > +F:     drivers/irqchip/irq-mips-gic.c
> > > > +F:     drivers/clocksource/mips-gic-timer.c
> > > > +F:     drivers/cpuidle/cpuidle-cps.c
> > >
> > > I think nowadays checkpatch.pl warns on wrong ordering in this data base.
> >
> > Alas it doesn't.
> 

> Ah, it definitely will.
> it was relatively recently added by:
> commit 9bbce40a4f72fe01a65669aee9f4036baa7fa26e
> Author: Joe Perches <joe@...ches.com>
> Date:   Tue May 26 10:36:34 2020 +1000
> 
>    checkpatch: additional MAINTAINER section entry ordering checks
> 
> 
> > Good point though.
> 
> You're welcome.

Next time I won't forget that then. BTW the notes at the top of the MAINTAINERS
file don't explicitly say about the files-list order. Only about the
whole maintainers list entries order. Seeing the rest of the sub-entries like
L:, M:, etc. aren't ordered then it's probably better to have an explicit
statement, that files should be alphabetically listed, especially when
checkpatch.pl starts warning about that.

-Sergey

> 
> -- 
> With Best Regards,
> Andy Shevchenko