linux-kernel - Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11986598-9357-dfdd-e187-c9eb0428fd62@inliniac.net>
Date:   Tue, 2 Jun 2020 06:23:54 +0200
From:   Victor Julien <victor@...iniac.net>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, corbet@....net,
        edumazet@...gle.com, willemb@...gle.com, maowenan@...wei.com,
        arnd@...db.de, nhorman@...driver.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] af-packet: new flag to indicate all csums are
 good

On 01-06-2020 23:45, David Miller wrote:
> From: Victor Julien <victor@...iniac.net>
> Date: Mon,  1 Jun 2020 22:49:37 +0200
> 
>> @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALID	This flag indicates that at least the transport
>>  			validated on the kernel side. If the flag is not set
>>  			then we are free to check the checksum by ourselves
>>  			provided that TP_STATUS_CSUMNOTREADY is also not set.
>> +TP_STATUS_CSUM_UNNECESSARY  This flag indicates that the driver validated all
>> +                        the packets csums. If it is not set it might be that
>> +                        the driver doesn't support this, or that one of the
>> +                        layers csums is bad. TP_STATUS_CSUM_VALID may still
>> +                        be set if the transport layer csum is correct or
>> +                        if the driver supports only this mode.
>>  ======================  =======================================================
>                         ^^^^^
> 
> I think you need to reformat these dividers.
> 

Yes of course. Think I'll have to reformat the whole table then, at
least for `rst2pdf` to accept it.

Alternatively I can try to come up with a shorter name for the flag, but
I'm not really coming up with anything so far.

-- 
---------------------------------------------
Victor Julien
http://www.inliniac.net/
PGP: http://www.inliniac.net/victorjulien.asc
---------------------------------------------