linux-kernel - Re: [PATCH] block/bio-integrity: don't free 'buf' if bio_integrity_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a4eb4b7-76f2-0b1c-c760-a09a76ee325a@kernel.dk>
Date:   Tue, 2 Jun 2020 16:44:57 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     yu kuai <yukuai3@...wei.com>, ming.lei@...hat.com,
        martin.petersen@...cle.com, wenwen@...uga.edu
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yi.zhang@...wei.com
Subject: Re: [PATCH] block/bio-integrity: don't free 'buf' if
 bio_integrity_add_page() failed

On 6/1/20 6:38 AM, yu kuai wrote:
> commit e7bf90e5afe3 ("block/bio-integrity: fix a memory leak bug") add a
> kree() for 'buf' if bio_integrity_add_page() return '0'. However, the
> object will be freed in bio_integrity_free() since 'bio->bi_opf' and
> 'bio->bi_integrity' was set previousy in bio_integrity_alloc().

Applied, thanks.

-- 
Jens Axboe