linux-kernel - Re: [PATCH] clk: baikal-t1: remove redundant assignment to variable 'divider'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 3 Jun 2020 02:25:40 +0300
From:   Serge Semin <Sergey.Semin@...kalelectronics.ru>
To:     Colin King <colin.king@...onical.com>
CC:     Serge Semin <fancer.lancer@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, <linux-clk@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: baikal-t1: remove redundant assignment to variable
 'divider'

On Tue, Jun 02, 2020 at 06:24:35PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable divider is being initialized with a value that is never read
> and it is being updated later with a new value.  The initialization is
> redundant and can be removed.

Right. Thanks.

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/clk/baikal-t1/ccu-div.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/baikal-t1/ccu-div.c b/drivers/clk/baikal-t1/ccu-div.c
> index bd40f5936f08..4062092d67f9 100644
> --- a/drivers/clk/baikal-t1/ccu-div.c
> +++ b/drivers/clk/baikal-t1/ccu-div.c
> @@ -248,7 +248,7 @@ static int ccu_div_var_set_rate_fast(struct clk_hw *hw, unsigned long rate,
>  				     unsigned long parent_rate)
>  {
>  	struct ccu_div *div = to_ccu_div(hw);
> -	unsigned long flags, divider = 1;
> +	unsigned long flags, divider;
>  	u32 val;
>  
>  	divider = ccu_div_var_calc_divider(rate, parent_rate, div->mask);
> -- 
> 2.25.1
>