linux-kernel - Re: [PATCH net-next v5] hinic: add set_channels ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <acb398e4-ffde-2753-03ca-cbed8933daff@huawei.com>
Date:   Tue, 2 Jun 2020 08:31:28 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <luoxianjun@...wei.com>, <yin.yinshi@...wei.com>,
        <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v5] hinic: add set_channels ethtool_ops support

On 2020/6/2 1:53, David Miller wrote:
> From: Luo bin <luobin9@...wei.com>
> Date: Mon, 1 Jun 2020 18:57:48 +0800
>
>> @@ -470,6 +470,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>>   	struct hinic_txq *txq;
>>   	struct hinic_qp *qp;
>>   
>> +	if (unlikely(!netif_carrier_ok(netdev))) {
>> +		dev_kfree_skb_any(skb);
>> +		return NETDEV_TX_OK;
>> +	}
> As stated by another reviewer, this change is unrelated to adding
> set_channels support.  Please remove it from this patch.
Will fix. Thanks.
> .