linux-kernel - Re: [v2] afs: Fix memory leak in afs_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Jun 2020 07:51:01 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     David Howells <dhowells@...hat.com>, linux-afs@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org
Cc:     Zhihao Cheng <chengzhihao1@...wei.com>,
        Yi Zhang <yi.zhang@...wei.com>, linux-kernel@...r.kernel.org
Subject: Re: [v2] afs: Fix memory leak in afs_put_sysnames()

>> * Is freeing and releasing an item a duplicate operation anyhow?
>
> You're missing the point.  afs_put_sysnames() does release the things the
> object points to (ie. the content),

It is possible to distinguish the release of system resources for further items.

> but not the object itself.

How does this view fit to the proposed addition "kfree(sysnames);"?
https://lore.kernel.org/linux-fsdevel/20200602013045.321855-1-chengzhihao1@huawei.com/
https://lore.kernel.org/patchwork/patch/1251323/

Regards,
Markus