linux-kernel - Re: [PATCH] lib: make a test module with get_count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Jun 2020 18:02:51 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Wei Yang <richard.weiyang@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: make a test module with get_count_order/long

On Sun, 31 May 2020 12:47:09 +0000 Wei Yang <richard.weiyang@...il.com> wrote:

> On Sun, May 31, 2020 at 12:56:29AM +0300, Andy Shevchenko wrote:
> >On Sun, May 31, 2020 at 12:23 AM Wei Yang <richard.weiyang@...il.com> wrote:
> >> On Sat, May 30, 2020 at 01:25:31PM +0300, Andy Shevchenko wrote:
> >> >On Sat, May 30, 2020 at 12:43:28AM +0000, Wei Yang wrote:
> >> >> A test module to make sure get_count_order/long returns the correct result.
> >> >
> >> >>  lib/Kconfig.debug                  | 13 ++++++
> >> >>  lib/Makefile                       |  2 +
> >> >>  lib/test_getorder.c                | 64 ++++++++++++++++++++++++++++++
> >> >
> >> >I didn't get why it's not a part of test_bitops?
> >> >
> >>
> >> I see the document of test_bitops says it does exercise on clear_bit and
> >> set_bit. So not sure it is proper to put them together.
> >
> >It's not a problem to amend a documentation as well :-)
> >
> 
> Sure. I am fine with this.
> 
> Andrew, do you expect me to merge it into test_bitops.c?
> 

Yes please.