linux-kernel - Re: [PATCH v2] iommu: Improve exception handling in iommu_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c6f587ac-aebe-3aae-da0e-087dc7f78ac5@web.de>
Date:   Tue, 2 Jun 2020 10:00:13 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Jörg Rödel <joro@...tes.org>,
        iommu@...ts.linux-foundation.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Qiushi Wu <wu000273@....edu>, Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH v2] iommu: Improve exception handling in
 iommu_group_alloc()

> Improve the exception handling to free the resources correctly when
> failed to allocate an iommu group.

I propose to avoid the specification of duplicate function calls.
Will it become helpful to add a few jump targets?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=f359287765c04711ff54fbd11645271d8e5ff763#n455

> ---
>  drivers/iommu/iommu.c | 10 ++++++++--

I suggest to replace the triple dashes before this diffstat
by a blank line.

Regards,
Markus